fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

WIP: Adding the menu #110

Draft
raphael wants to merge 13 commits from new-menu into main
pull from: new-menu
merge into: fish-cannard:main
Conversation 0 Commits 13 Files changed 15 +298 -57
raphael commented 2024-04-04 21:13:31 +00:00
Owner
Copy link

closes : #39

closes : #39
raphael added the
Kind/Enhancement
Kind/Feature
 labels 2024-04-04 21:13:31 +00:00
raphael self-assigned this 2024-04-04 21:13:31 +00:00
raphael added 6 commits 2024-04-04 21:13:32 +00:00
commit
Some checks are pending
Rust Checks / checks (push) Waiting to run
Details
c6e9206213
Merge branch 'main' into new-menu
Some checks failed
Rust Checks / checks (push) Failing after 6s
Details
ed49d489b4
info.png
Some checks failed
Rust Checks / checks (push) Failing after 5s
Details
c5811543c6
add hover image
Some checks failed
Rust Checks / checks (push) Failing after 6s
Details
311d153a5e
wip
Some checks failed
Rust Checks / checks (push) Failing after 5s
Details
3f99f0ab5d
Ajout de l'ui du menu
Some checks failed
Rust Checks / checks (push) Failing after 6s
Details
Rust Checks / checks (pull_request) Failing after 6s
Details
af1d9d7159
raphael changed title from WIP: Adding a the menu to WIP: Adding the menu 2024-04-04 21:13:54 +00:00
raphael requested review from CoCo_Sol 2024-04-04 21:14:28 +00:00
tipragot requested changes 2024-04-04 21:19:55 +00:00
crates/border-wars/src/scenes/menu.rs Outdated
@ -15,2 +16,3 @@
fn build(&self, app: &mut App) {
app.add_systems(Update, menu_ui.run_if(in_state(CurrentScene::Menu)));
// app.add_systems(Update, menu_ui.run_if(in_state(CurrentScene::Menu)));
app.add_systems(OnEnter(CurrentScene::Menu), menu_ui2);
tipragot commented 2024-04-04 21:16:26 +00:00
Contributor
Copy link

2 ?

2 ?
crates/border-wars/src/scenes/menu.rs Outdated
@ -78,0 +86,4 @@
type TargetScene = CurrentScene;
fn menu_ui2(mut commands: Commands, asset_server: Res<AssetServer>) {
commands
tipragot commented 2024-04-04 21:17:29 +00:00
Contributor
Copy link

Put some comments to tell which élément you are creating

Put some comments to tell which élément you are creating
crates/border-wars/src/scenes/menu.rs Outdated
@ -78,0 +288,4 @@
}
fn render<T: Bundle>(
tipragot commented 2024-04-04 21:19:47 +00:00
Contributor
Copy link

This does not render anything, it only create ui elements

This does not render anything, it only create ui elements
CoCo_Sol added 1 commit 2024-04-05 05:47:37 +00:00
Merge branch 'main' into new-menu
Some checks failed
Rust Checks / checks (push) Failing after 7s
Details
Rust Checks / checks (pull_request) Failing after 5s
Details
72965f1e03
CoCo_Sol added 1 commit 2024-04-05 06:27:54 +00:00
Merge branch 'main' into new-menu
Some checks failed
Rust Checks / checks (push) Failing after 6s
Details
Rust Checks / checks (pull_request) Failing after 5s
Details
0732dd0b11
CoCo_Sol added 1 commit 2024-04-05 06:34:41 +00:00
improuve type
Some checks failed
Rust Checks / checks (push) Failing after 2m59s
Details
Rust Checks / checks (pull_request) Failing after 2m45s
Details
20a9bcf08f
CoCo_Sol requested changes 2024-04-05 06:37:45 +00:00
CoCo_Sol left a comment
Owner
Copy link

You should :

  • Fix all clippy issues
You should : - Fix all clippy issues
CoCo_Sol added 1 commit 2024-04-05 20:53:18 +00:00
improve hoverd texture
Some checks failed
Rust Checks / checks (push) Failing after 2m40s
Details
Rust Checks / checks (pull_request) Failing after 2m32s
Details
f130b923cc
raphael added 1 commit 2024-04-06 12:44:26 +00:00
renaming
Some checks failed
Rust Checks / checks (push) Failing after 2m16s
Details
Rust Checks / checks (pull_request) Failing after 2m10s
Details
43f9eac55f
raphael added 1 commit 2024-04-06 14:37:16 +00:00
UI
Some checks failed
Rust Checks / checks (push) Failing after 3m8s
Details
Rust Checks / checks (pull_request) Failing after 3m23s
Details
f9eb0c0e1e
raphael added 1 commit 2024-04-06 14:42:45 +00:00
save
Some checks failed
Rust Checks / checks (push) Failing after 6s
Details
Rust Checks / checks (pull_request) Failing after 5s
Details
6a5eed3979
Some checks failed
Rust Checks / checks (push) Failing after 6s
Required
Details
Rust Checks / checks (pull_request) Failing after 5s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin new-menu:new-menu
git checkout new-menu
Sign in to join this conversation.
Reviewers
No reviewers
tipragot
CoCo_Sol
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Fix

Fix an issue

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Fix
Kind/Security
Kind/Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
raphael
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fish-cannard/border-wars#110
No description provided.
Delete branch "new-menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?