Tipragot

tipragot commented on pull request fish-cannard/border-wars#57

2024-02-20 01:32:42 +00:00

Adding a map creation plugin

If the End event start with "End" why this don't start with "Start" ?

tipragot commented on pull request fish-cannard/border-wars#57

2024-02-20 01:32:42 +00:00

Adding a map creation plugin

You can use the let else syntax to remove one level of nesting.

tipragot commented on pull request fish-cannard/border-wars#57

2024-02-20 01:32:42 +00:00

Adding a map creation plugin

Why don't you use HexPosition here?

tipragot commented on pull request fish-cannard/border-wars#57

2024-02-20 01:32:42 +00:00

Adding a map creation plugin

This comment is wrong.

tipragot commented on pull request fish-cannard/border-wars#57

2024-02-20 01:32:42 +00:00

Adding a map creation plugin

Isize will not be great to use for networking because it's length depend on the system that runs the program.

tipragot suggested changes for fish-cannard/border-wars#57

2024-02-20 01:32:42 +00:00

Adding a map creation plugin

tipragot commented on pull request fish-cannard/border-wars#57

2024-02-18 18:06:50 +00:00

Adding a map creation plugin

You should follow the bevy convention. Events in bevy doen't finish with "Event".

tipragot suggested changes for fish-cannard/border-wars#57

2024-02-18 18:06:50 +00:00

Adding a map creation plugin

tipragot approved fish-cannard/border-wars#58

2024-02-18 18:05:31 +00:00

Fix the error in the distance calculation function

tipragot commented on pull request fish-cannard/border-wars#57

2024-02-16 22:21:04 +00:00

Adding a map creation plugin

Put an UPPERCASE "s"

tipragot suggested changes for fish-cannard/border-wars#57

2024-02-16 22:21:04 +00:00

Adding a map creation plugin

The system needs to clean the last generated map, and I think it will be usefull to add an event to tell when the generation is ended.

tipragot approved fish-cannard/border-wars#55

2024-02-16 21:11:47 +00:00

Remake utils for hexagon grids

tipragot deleted branch improve-hex-utils from fish-cannard/border-wars

2024-02-15 09:50:19 +00:00

tipragot pushed to main at fish-cannard/border-wars

2024-02-15 09:50:18 +00:00

dae48df64a Improve utils by adding pixel conversion (#52)

tipragot merged pull request fish-cannard/border-wars#52

2024-02-15 09:50:16 +00:00

Improve utils by adding pixel conversion

tipragot approved fish-cannard/border-wars#52

2024-02-15 09:50:11 +00:00

Improve utils by adding pixel conversion

tipragot deleted branch change-struct-map from fish-cannard/border-wars

2024-02-14 18:18:21 +00:00

tipragot pushed to main at fish-cannard/border-wars

2024-02-14 18:18:18 +00:00

663a4160a2 Changing the structure of map-related programmes (#51)

tipragot merged pull request fish-cannard/border-wars#51

2024-02-14 18:18:17 +00:00

Changing the structure of map-related programmes

tipragot approved fish-cannard/border-wars#51

2024-02-14 18:18:10 +00:00

Changing the structure of map-related programmes