fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Implement generic online system #82

Merged
CoCo_Sol merged 14 commits from impl-online into main 2024-03-25 05:45:17 +00:00
Conversation 0 Commits 14 Files changed 9 +228 -13
CoCo_Sol commented 2024-03-20 16:05:38 +00:00
Owner
Copy link

note that the feature of adding a system to check if players are still connected will be in a new pull request.

note that the feature of adding a system to check if players are still connected will be in a new pull request.
CoCo_Sol added this to the Gameplay milestone 2024-03-20 16:05:38 +00:00
CoCo_Sol added the
Kind/Feature
 label 2024-03-20 16:05:38 +00:00
CoCo_Sol self-assigned this 2024-03-20 16:05:38 +00:00
CoCo_Sol added 1 commit 2024-03-20 16:05:39 +00:00
save
All checks were successful
Rust Checks / checks (push) Successful in 4m39s
Details
Rust Checks / checks (pull_request) Successful in 2m45s
Details
56cff5d69e
CoCo_Sol added 1 commit 2024-03-20 16:31:01 +00:00
save
Some checks failed
Rust Checks / checks (push) Failing after 3m0s
Details
Rust Checks / checks (pull_request) Failing after 2m45s
Details
568d69a250
CoCo_Sol added 1 commit 2024-03-20 17:40:51 +00:00
save
All checks were successful
Rust Checks / checks (push) Successful in 2m44s
Details
Rust Checks / checks (pull_request) Successful in 2m1s
Details
6dd6cfc3b7
CoCo_Sol added 2 commits 2024-03-21 08:12:26 +00:00
Merge branch 'main' into impl-online
Some checks are pending
Rust Checks / checks (push) Waiting to run
Details
Rust Checks / checks (pull_request) Successful in 4m27s
Details
ad98176321
CoCo_Sol added 1 commit 2024-03-21 08:24:45 +00:00
save
Some checks failed
Rust Checks / checks (push) Has been cancelled
Details
Rust Checks / checks (pull_request) Successful in 2m47s
Details
e4ead79cb1
CoCo_Sol added 1 commit 2024-03-21 08:26:33 +00:00
rename
Some checks are pending
Rust Checks / checks (push) Waiting to run
Details
Rust Checks / checks (pull_request) Successful in 2m25s
Details
4fe4bdba3f
CoCo_Sol added 1 commit 2024-03-21 08:28:38 +00:00
opti de la mort qui tue
All checks were successful
Rust Checks / checks (push) Successful in 2m25s
Details
Rust Checks / checks (pull_request) Successful in 2m2s
Details
cd8b181f1d
CoCo_Sol added 1 commit 2024-03-21 08:53:20 +00:00
SAVE
All checks were successful
Rust Checks / checks (push) Successful in 2m7s
Details
Rust Checks / checks (pull_request) Successful in 2m5s
Details
49ee6daa8e
CoCo_Sol added 1 commit 2024-03-21 09:07:55 +00:00
save
All checks were successful
Rust Checks / checks (push) Successful in 2m4s
Details
Rust Checks / checks (pull_request) Successful in 2m10s
Details
0d048b3a57
CoCo_Sol added 1 commit 2024-03-21 21:01:20 +00:00
remove fonction
All checks were successful
Rust Checks / checks (push) Successful in 3m43s
Details
Rust Checks / checks (pull_request) Successful in 2m40s
Details
1bcb81be0b
CoCo_Sol added 1 commit 2024-03-21 21:18:32 +00:00
update
All checks were successful
Rust Checks / checks (push) Successful in 3m1s
Details
Rust Checks / checks (pull_request) Successful in 2m6s
Details
417825d038
CoCo_Sol changed title from WIP: Implement generic online system to Implement generic online system 2024-03-21 21:20:01 +00:00
CoCo_Sol requested review from raphael 2024-03-21 21:20:12 +00:00
raphael reviewed 2024-03-21 21:33:50 +00:00
crates/border-wars/src/networking/connection.rs Outdated
@ -0,0 +40,4 @@
connection: Res<Connection>,
state: Res<State<CurrentScene>>,
) {
// Check if the player is an admin
raphael commented 2024-03-21 21:33:50 +00:00
Owner
Copy link

Pas compris pk il doit être admin ni qui est le joueur en question

Pas compris pk il doit être admin ni qui est le joueur en question
CoCo_Sol marked this conversation as resolved
raphael reviewed 2024-03-21 21:35:56 +00:00
crates/border-wars/src/networking/mod.rs Outdated
@ -0,0 +26,4 @@
/// The player is a spectator. He does not play the game.
Spectator,
/// The player is an admin. He can remove players.
raphael commented 2024-03-21 21:35:56 +00:00
Owner
Copy link

Es ce que l'admin peut aussi jouer ?

Es ce que l'admin peut aussi jouer ?
CoCo_Sol marked this conversation as resolved
tipragot requested changes 2024-03-21 21:48:39 +00:00
Dismissed
tipragot left a comment
Contributor
Copy link

The client does not check if the requests come from the server

The client does not check if the requests come from the server
tipragot dismissed tipragot's review 2024-03-21 21:52:07 +00:00
Reason:

I am dumb

tipragot requested changes 2024-03-21 21:55:33 +00:00
tipragot left a comment
Contributor
Copy link

I think you shoud use entities to store players to better use bevy features. And also you should separate functionnalities instead of putting everything in the same function (handle_change_player)

I think you shoud use entities to store players to better use bevy features. And also you should separate functionnalities instead of putting everything in the same function (handle_change_player)
CoCo_Sol added 1 commit 2024-03-23 22:05:24 +00:00
edit struct
All checks were successful
Rust Checks / checks (push) Successful in 5m17s
Details
Rust Checks / checks (pull_request) Successful in 2m59s
Details
89861980fa
CoCo_Sol requested review from tipragot 2024-03-24 16:43:27 +00:00
raphael approved these changes 2024-03-24 17:24:59 +00:00
Dismissed
CoCo_Sol added 1 commit 2024-03-24 21:04:57 +00:00
Merge branch 'main' into impl-online
All checks were successful
Rust Checks / checks (push) Successful in 3m49s
Details
Rust Checks / checks (pull_request) Successful in 2m45s
Details
5b2944f187
CoCo_Sol dismissed raphael's review 2024-03-24 21:04:58 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

raphael approved these changes 2024-03-24 21:26:02 +00:00
CoCo_Sol merged commit 5848272f4a into main 2024-03-25 05:45:16 +00:00
CoCo_Sol deleted branch impl-online 2024-03-25 05:45:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tipragot
raphael
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Fix

Fix an issue

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Fix
Kind/Security
Kind/Testing
Milestone
Clear milestone
No items
No milestone
Gameplay
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
CoCo_Sol
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fish-cannard/border-wars#82
No description provided.
Delete branch "impl-online"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?