Tipragot tipragot

2 followers · 7 following

• Joined on 2023-06-13

Repositories

6

Projects Packages Public activity Starred repositories

3

tipragot pushed to opti at fish-cannard/border-wars 2024-02-22 16:33:54 +00:00

392594eefb Make the build time faster for development

tipragot created branch opti in fish-cannard/border-wars 2024-02-22 16:33:53 +00:00

tipragot created pull request fish-cannard/border-wars#62 2024-02-22 16:05:14 +00:00

Remove useless dependencies

tipragot pushed to remove-dependencies at fish-cannard/border-wars 2024-02-22 16:04:24 +00:00

dd9a07ffdf Remove useless dependencies

tipragot created branch remove-dependencies in fish-cannard/border-wars 2024-02-22 16:04:23 +00:00

tipragot approved fish-cannard/border-wars#57 2024-02-21 18:04:45 +00:00

Adding a map creation plugin

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-21 17:57:51 +00:00

Adding a map creation plugin

This is not a Zoom, it is a Scale

tipragot suggested changes for fish-cannard/border-wars#57 2024-02-21 17:57:51 +00:00

Adding a map creation plugin

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-21 17:48:58 +00:00

Adding a map creation plugin

Perlin isn't a function

tipragot suggested changes for fish-cannard/border-wars#57 2024-02-21 17:48:58 +00:00

Adding a map creation plugin

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-21 17:48:57 +00:00

Adding a map creation plugin

get_tile_type

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-21 17:15:25 +00:00

Adding a map creation plugin

What this ":" doing here ?

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-21 17:15:25 +00:00

Adding a map creation plugin

This should be un the get_type function and the value shouldn't be hard coded

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-21 17:15:25 +00:00

Adding a map creation plugin

I still think you should take an HexPosition, this will be simpler and will make this function simpler to use.

tipragot suggested changes for fish-cannard/border-wars#57 2024-02-21 17:15:25 +00:00

Adding a map creation plugin

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-21 06:51:23 +00:00

Adding a map creation plugin

No, an let else

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-20 12:40:59 +00:00

Adding a map creation plugin

No because you do an early return

tipragot approved fish-cannard/border-wars#59 2024-02-20 11:07:43 +00:00

Unify languages in readme

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-20 11:01:26 +00:00

Adding a map creation plugin

You need to change the name of the function or take an HexPosition and convert it in the function, because it can be confusing that you use "tile" to describe the orthogonal position of an HexPosition

tipragot commented on pull request fish-cannard/border-wars#57 2024-02-20 10:59:13 +00:00

Adding a map creation plugin

You will use it every time you want to make a Query on the HexPosition