raphael/gtn
2
1
Fork 0
Code Issues 2 Pull requests Packages Projects Releases 1 Wiki Activity

assets update + hoverable component #23

Merged
tipragot merged 9 commits from menu into main 2023-10-27 22:29:36 +00:00
Conversation 0 Commits 9 Files changed 11 +59 -25
CoCo_Sol commented 2023-10-27 21:01:48 +00:00
Collaborator
Copy link
No description provided.
CoCo_Sol added 2 commits 2023-10-27 21:01:49 +00:00
CoCo_Sol added 1 commit 2023-10-27 21:08:21 +00:00
tipragot requested changes 2023-10-27 21:10:30 +00:00
tipragot left a comment
Collaborator
Copy link

Utilise la dernière version de main (merge main dans ta branche).
Et fait un teste dans main.py pour montrer que ton plugin marche bien.

Utilise la dernière version de main (merge main dans ta branche). Et fait un teste dans main.py pour montrer que ton plugin marche bien.
src/engine/plugins/hover.py Outdated
@ -55,0 +74,4 @@
self.callback = callback
def _update(self, world: World, entity: Entity) -> None:
self.callback = self.update_callback
tipragot commented 2023-10-27 21:10:04 +00:00
Collaborator
Copy link

Je ne comprend pas l'utilité de cette fonction.

Je ne comprend pas l'utilité de cette fonction.
CoCo_Sol marked this conversation as resolved
CoCo_Sol added 1 commit 2023-10-27 21:22:39 +00:00
CoCo_Sol requested review from tipragot 2023-10-27 21:23:30 +00:00
tipragot requested changes 2023-10-27 21:34:01 +00:00
tipragot left a comment
Collaborator
Copy link

Il manque toujours un example dans main.py

Il manque toujours un example dans main.py
src/engine/plugins/hover.py Outdated
@ -25,0 +26,4 @@
# on execute les update de toutes les entities qui ont le composant Hover et qui sont hoverable
if Hover in entity and Hoverable in entity:
entity[Hoverable].update_callback(world, entity)
tipragot commented 2023-10-27 21:33:42 +00:00
Collaborator
Copy link

Pourquoi ne pas le faire dans la condition en dessous ?

Pourquoi ne pas le faire dans la condition en dessous ?
CoCo_Sol commented 2023-10-27 21:39:24 +00:00
Author
Collaborator
Copy link

on peux mais le component hover ne sert plus a rien.
(a part si on l'utilise dans le code du jeu mais je vois pas trop ou)

on peux mais le component hover ne sert plus a rien. (a part si on l'utilise dans le code du jeu mais je vois pas trop ou)
CoCo_Sol marked this conversation as resolved
src/engine/plugins/hover.py Outdated
@ -55,0 +78,4 @@
self.update_callback = update_callback
self.init_callback = init_callback
self.end_callback = end_callback
tipragot commented 2023-10-27 21:32:33 +00:00
Collaborator
Copy link

Plutot enter_callback et exit_callback non ?

Plutot enter_callback et exit_callback non ?
CoCo_Sol marked this conversation as resolved
CoCo_Sol added 1 commit 2023-10-27 21:58:50 +00:00
CoCo_Sol requested review from tipragot 2023-10-27 21:59:28 +00:00
CoCo_Sol added 1 commit 2023-10-27 22:00:48 +00:00
tipragot requested changes 2023-10-27 22:02:51 +00:00
tipragot left a comment
Collaborator
Copy link

Erreur mypy:

src\engine\plugins\hover.py:74: error: Incompatible default for argument "entry_callback" (default has type "Callable[[World, Entity], tuple[()]]", argument has type "Callable[[World, Entity], None]")  [assignment]
src\engine\plugins\hover.py:75: error: Incompatible default for argument "update_callback" (default has type "Callable[[World, Entity], tuple[()]]", argument has type "Callable[[World, Entity], None]")  [assignment]
src\engine\plugins\hover.py:76: error: Incompatible default for argument "exit_callback" (default has type "Callable[[World, Entity], tuple[()]]", argument has type "Callable[[World, Entity], None]")  [assignment]
Found 3 errors in 1 file (checked 9 source files)

Sur vscode utilise f5 pour lancer le main.py et faire les checks

Erreur mypy: ``` src\engine\plugins\hover.py:74: error: Incompatible default for argument "entry_callback" (default has type "Callable[[World, Entity], tuple[()]]", argument has type "Callable[[World, Entity], None]") [assignment] src\engine\plugins\hover.py:75: error: Incompatible default for argument "update_callback" (default has type "Callable[[World, Entity], tuple[()]]", argument has type "Callable[[World, Entity], None]") [assignment] src\engine\plugins\hover.py:76: error: Incompatible default for argument "exit_callback" (default has type "Callable[[World, Entity], tuple[()]]", argument has type "Callable[[World, Entity], None]") [assignment] Found 3 errors in 1 file (checked 9 source files) ``` Sur vscode utilise f5 pour lancer le main.py et faire les checks
CoCo_Sol added 1 commit 2023-10-27 22:08:55 +00:00
CoCo_Sol added 1 commit 2023-10-27 22:15:36 +00:00
tipragot added 1 commit 2023-10-27 22:27:38 +00:00
tipragot approved these changes 2023-10-27 22:29:24 +00:00
tipragot merged commit 1facab98aa into main 2023-10-27 22:29:36 +00:00
tipragot deleted branch menu 2023-10-27 22:29:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tipragot
Labels
Clear labels   
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Fix

Fix an issue

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

No labels
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Fix
Kind/Security
Kind/Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: raphael/gtn#23
No description provided.
Delete branch "menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?