fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Adding a map creation plugin #57

Merged
CoCo_Sol merged 39 commits from map-generation into main 2024-02-21 20:10:03 +00:00
Conversation 0 Commits 39 Files changed 5 +1 -2
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d3c89956a1 - Show all commits

3
crates/border-wars/src/map/generation.rs
View file

@ -65,13 +65,12 @@ fn generate_map(
fn get_type_tile(position: (f32, f32), noise: &Perlin) -> Tile {
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-20 01:26:47 +00:00
Outdated
Review
Copy link

Why don't you use HexPosition here?

Why don't you use HexPosition here?
CoCo_Sol commented 2024-02-20 10:29:48 +00:00
Outdated
Review
Copy link

because is not a hex position in a hex grid but a position in orthogonal grid

because is not a hex position in a hex grid but a position in orthogonal grid
tipragot commented 2024-02-20 11:01:26 +00:00
Outdated
Review
Copy link

You need to change the name of the function or take an HexPosition and convert it in the function, because it can be confusing that you use "tile" to describe the orthogonal position of an HexPosition

You need to change the name of the function or take an HexPosition and convert it in the function, because it can be confusing that you use "tile" to describe the orthogonal position of an HexPosition
CoCo_Sol commented 2024-02-20 11:08:42 +00:00
Outdated
Review
Copy link

you are right

you are right
CoCo_Sol marked this conversation as resolved
tipragot commented 2024-02-21 17:10:20 +00:00
Review
Copy link

This should be in the get_type function and the value shouldn't be hard coded

This should be in the get_type function and the value shouldn't be hard coded
let value = noise.get([position.0 as f64, position.1 as f64]);
match value {
v if v <= -0.5 => Tile::Hill, // Réduire le seuil pour les collines
v if v <= -0.5 => Tile::Hill, // Réduire le seuil pour les collines
v if v >= 0.5 => Tile::Forest, // Réduire le seuil pour les forêts
_ => Tile::Grass,
}
}
/// Despawns the tiles if the event : [EndMapGenerationEvent] is received.
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-20 01:29:16 +00:00
Outdated
Review
Copy link

This comment is wrong.

This comment is wrong.
fn delete_map(
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:11:09 +00:00
Outdated
Review
Copy link

I still think you should take an HexPosition, this will be simpler and will make this function simpler to use.

I still think you should take an HexPosition, this will be simpler and will make this function simpler to use.
mut commands: Commands,