fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Adding a map creation plugin #57

Merged
CoCo_Sol merged 39 commits from map-generation into main 2024-02-21 20:10:03 +00:00
Conversation 0 Commits 39 Files changed 5 +1 -2
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 744d9b646e - Show all commits

3
crates/border-wars/src/map/generation.rs
View file

@ -52,7 +52,6 @@ fn generate_map(
if let (Some(perlin), Some(spiral)) = (noise.as_ref(), map_iterator.as_mut()) {
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-20 01:25:17 +00:00
Outdated
Review
Copy link

You can use the let else syntax to remove one level of nesting.

You can use the let else syntax to remove one level of nesting.
CoCo_Sol commented 2024-02-20 10:38:52 +00:00
Outdated
Review
Copy link

if I use the "else let" keyword, the nesting level is the same

if I use the "else let" keyword, the nesting level is the same
tipragot commented 2024-02-20 12:40:58 +00:00
Outdated
Review
Copy link

No because you do an early return

No because you do an early return
CoCo_Sol commented 2024-02-20 20:15:57 +00:00
Outdated
Review
Copy link

I have to write an unwrap so ?

I have to write an unwrap so ?
tipragot commented 2024-02-21 06:51:23 +00:00
Outdated
Review
Copy link

No, an let else

No, an let else
if let Some(position) = spiral.next() {
let pixel_position = position.to_pixel_coordinates((0.1, 0.1));
commands.spawn((get_type_tile(pixel_position, perlin), position));
} else {
end_map_event.send(EndMapGenerationEvent);
@ -76,7 +75,7 @@ fn get_type_tile(position: (f32, f32), noise: &Perlin) -> Tile {
fn delete_map(
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:11:09 +00:00
Outdated
Review
Copy link

I still think you should take an HexPosition, this will be simpler and will make this function simpler to use.

I still think you should take an HexPosition, this will be simpler and will make this function simpler to use.
mut commands: Commands,
query: Query<Entity, With<Tile>>,
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:47:05 +00:00
Outdated
Review
Copy link

get_tile_type

get_tile_type
mut event: EventReader<EndMapGenerationEvent>,
mut event: EventReader<MapGenerationEvent>,
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:57:49 +00:00
Outdated
Review
Copy link

This is not a Zoom, it is a Scale

This is not a Zoom, it is a Scale
) {
for _ in event.read() {
for entity in query.iter() {