fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Adding a map creation plugin #57

Merged
CoCo_Sol merged 39 commits from map-generation into main 2024-02-21 20:10:03 +00:00
Conversation 0 Commits 39 Files changed 5 +2 -3
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6f061deb34 - Show all commits

5
crates/border-wars/src/map/generation.rs
View file

@ -4,8 +4,7 @@ use bevy::prelude::*;
use noise::{NoiseFn, Perlin};
use super::hex::*;
use super::Tile;
use super::TilePosition;
use super::{Tile, TilePosition};
/// A plugin to handle the map generation.
pub struct MapGenerationPlugin;
@ -47,7 +46,7 @@ fn generate_map(
// Handle map generation events.
for event in event.read() {
*local_noise = Some(Perlin::new(event.seed));
*local_spiral = Some(TilePosition::new(0,0).spiral(event.radius as usize));
*local_spiral = Some(TilePosition::new(0, 0).spiral(event.radius as usize));
}
let (Some(noise), Some(spiral)) = (local_noise.as_ref(), local_spiral.as_mut()) else {
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-20 01:25:17 +00:00
Outdated
Review
Copy link

You can use the let else syntax to remove one level of nesting.

You can use the let else syntax to remove one level of nesting.
CoCo_Sol commented 2024-02-20 10:38:52 +00:00
Outdated
Review
Copy link

if I use the "else let" keyword, the nesting level is the same

if I use the "else let" keyword, the nesting level is the same
tipragot commented 2024-02-20 12:40:58 +00:00
Outdated
Review
Copy link

No because you do an early return

No because you do an early return
CoCo_Sol commented 2024-02-20 20:15:57 +00:00
Outdated
Review
Copy link

I have to write an unwrap so ?

I have to write an unwrap so ?
tipragot commented 2024-02-21 06:51:23 +00:00
Outdated
Review
Copy link

No, an let else

No, an let else