fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Adding a map creation plugin #57

Merged
CoCo_Sol merged 39 commits from map-generation into main 2024-02-21 20:10:03 +00:00
Conversation 0 Commits 39 Files changed 5 +2 -2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 0caf97d9b8 - Show all commits

4
crates/border-wars/src/map/generation.rs
View file

@ -40,7 +40,7 @@ pub struct EndMapGeneration;
/// Generate each tiles of the map if the [StartMapGeneration] is received.
///
/// The map is generated using the [Perlin] noise function and the [HexSpiral].
/// The map is generated using a [Perlin] noise and a [HexSpiral].
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:47:19 +00:00
Outdated
Review
Copy link

Perlin isn't a function

Perlin isn't a function
///
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-20 01:31:50 +00:00
Outdated
Review
Copy link

Isize will not be great to use for networking because it's length depend on the system that runs the program.
Also you should use type to alias a specific type for the HexPosition used for the map.

Isize will not be great to use for networking because it's length depend on the system that runs the program. Also you should use `type` to alias a specific type for the HexPosition used for the map.
CoCo_Sol commented 2024-02-20 10:33:51 +00:00
Outdated
Review
Copy link

I use only one time the hex position, is it really better to create a new type ?

I use only one time the hex position, is it really better to create a new type ?
tipragot commented 2024-02-20 10:59:12 +00:00
Outdated
Review
Copy link

You will use it every time you want to make a Query on the HexPosition

You will use it every time you want to make a Query on the HexPosition
CoCo_Sol commented 2024-02-20 11:07:36 +00:00
Outdated
Review
Copy link

ok, you've convinced me

ok, you've convinced me
/// It's generated one tile at a time, until the spiral is finished.
fn generate_map(
@ -74,7 +74,7 @@ fn generate_map(
}
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-20 01:29:16 +00:00
Outdated
Review
Copy link

This comment is wrong.

This comment is wrong.
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:11:09 +00:00
Outdated
Review
Copy link

I still think you should take an HexPosition, this will be simpler and will make this function simpler to use.

I still think you should take an HexPosition, this will be simpler and will make this function simpler to use.
/// Returns the type of the [HexPosition] with the given noise.
fn get_type_tile(position: HexPosition<i32>, noise: &Perlin) -> Tile {
fn get_tile_type(position: HexPosition<i32>, noise: &Perlin) -> Tile {
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:47:05 +00:00
Outdated
Review
Copy link

get_tile_type

get_tile_type
let pixel_position = position.to_pixel_coordinates() / MAP_GENERATION_ZOOM;
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-21 17:57:49 +00:00
Outdated
Review
Copy link

This is not a Zoom, it is a Scale

This is not a Zoom, it is a Scale
let value = noise.get([pixel_position.x as f64, pixel_position.y as f64]);
match value {