fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Adding a map creation plugin #57

Merged
CoCo_Sol merged 39 commits from map-generation into main 2024-02-21 20:10:03 +00:00
Conversation 0 Commits 39 Files changed 5 +1 -2
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 066561ff6c - Show all commits

3
crates/border-wars/src/map/generation.rs
View file

@ -44,9 +44,8 @@ fn generate_map(
if let (Some(perlin), Some(spiral)) = (noise.as_ref(), map_iterator.as_mut()) {
CoCo_Sol marked this conversation as resolved Outdated
tipragot commented 2024-02-20 01:31:50 +00:00
Outdated
Review
Copy link

Isize will not be great to use for networking because it's length depend on the system that runs the program.
Also you should use type to alias a specific type for the HexPosition used for the map.

Isize will not be great to use for networking because it's length depend on the system that runs the program. Also you should use `type` to alias a specific type for the HexPosition used for the map.
CoCo_Sol commented 2024-02-20 10:33:51 +00:00
Outdated
Review
Copy link

I use only one time the hex position, is it really better to create a new type ?

I use only one time the hex position, is it really better to create a new type ?
tipragot commented 2024-02-20 10:59:12 +00:00
Outdated
Review
Copy link

You will use it every time you want to make a Query on the HexPosition

You will use it every time you want to make a Query on the HexPosition
CoCo_Sol commented 2024-02-20 11:07:36 +00:00
Outdated
Review
Copy link

ok, you've convinced me

ok, you've convinced me
if let Some(position) = spiral.next() {
let pixel_position = position.to_pixel_coordinates((0.1, 0.1));
let type_tile = get_type_tile(pixel_position, perlin);
commands.spawn((type_tile, position));
commands.spawn((get_type_tile(pixel_position, perlin), position));
} else {
*noise = None;
*map_iterator = None;