fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Fix crashes due to Responsive scaling #91

Merged
raphael merged 2 commits from fiw-reponsive(scaling into main 2024-03-31 16:27:32 +00:00
Conversation 0 Commits 2 Files changed 1 +3
raphael commented 2024-03-31 16:21:07 +00:00
Owner
Copy link
No description provided.
raphael added the
Kind/Fix
 label 2024-03-31 16:21:07 +00:00
raphael self-assigned this 2024-03-31 16:21:07 +00:00
raphael added 1 commit 2024-03-31 16:21:08 +00:00
commit
All checks were successful
Rust Checks / checks (push) Successful in 3m47s
Details
Rust Checks / checks (pull_request) Successful in 2m51s
Details
d2698a9497
raphael requested review from CoCo_Sol 2024-03-31 16:21:18 +00:00
CoCo_Sol approved these changes 2024-03-31 16:22:46 +00:00
Dismissed
tipragot requested changes 2024-03-31 16:23:45 +00:00
crates/border-wars/src/responsive_scale.rs Outdated
@ -29,6 +29,9 @@ pub fn change_scaling(
size: Res<UILayoutSize>,
) {
let window = windows.get_single().expect("Main window not found");
if !window.resolution.physical_height() > 0 {
tipragot commented 2024-03-31 16:23:43 +00:00
Contributor
Copy link

<=

<=
raphael added 1 commit 2024-03-31 16:25:48 +00:00
sad
Some checks failed
Rust Checks / checks (push) Failing after 2m39s
Details
Rust Checks / checks (pull_request) Failing after 2m12s
Details
b84f076a49
raphael dismissed CoCo_Sol's review 2024-03-31 16:25:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

raphael requested review from tipragot 2024-03-31 16:26:13 +00:00
tipragot approved these changes 2024-03-31 16:26:39 +00:00
CoCo_Sol approved these changes 2024-03-31 16:27:17 +00:00
raphael merged commit ceca7d3681 into main 2024-03-31 16:27:32 +00:00
raphael deleted branch fiw-reponsive(scaling 2024-03-31 16:27:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tipragot
CoCo_Sol
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Fix

Fix an issue

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Fix
Kind/Security
Kind/Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
raphael
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fish-cannard/border-wars#91
No description provided.
Delete branch "fiw-reponsive(scaling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?