fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Renaming WindowSize #77

Merged
raphael merged 3 commits from rename-window-size into main 2024-03-09 17:53:35 +00:00
Conversation 0 Commits 3 Files changed 1 +7 -7
raphael commented 2024-03-09 17:42:18 +00:00
Owner
Copy link
No description provided.
raphael added 1 commit 2024-03-09 17:42:19 +00:00
Renaming WindowSize to UIWindowSize and correct doc string
All checks were successful
Rust Checks / checks (push) Successful in 3m24s
Details
Rust Checks / checks (pull_request) Successful in 3m26s
Details
285b75fe1a
raphael requested review from tipragot 2024-03-09 17:42:33 +00:00
tipragot requested changes 2024-03-09 17:43:07 +00:00
crates/border-wars/src/responsive_scale.rs Outdated
@ -13,3 +13,3 @@
}
/// The default window size.
/// The default ui window size.
tipragot commented 2024-03-09 17:43:04 +00:00
Contributor
Copy link

This is not a window

This is not a window
raphael added 1 commit 2024-03-09 17:49:07 +00:00
Renaming UIWindowSize to UILayoutSize
Some checks failed
Rust Checks / checks (push) Has been cancelled
Details
Rust Checks / checks (pull_request) Successful in 2m43s
Details
49fd625e97
raphael changed title from Renaming WindowSize to UIWindowSize and correct doc string to Renaming WindowSize 2024-03-09 17:49:26 +00:00
raphael requested review from tipragot 2024-03-09 17:49:35 +00:00
tipragot requested changes 2024-03-09 17:50:31 +00:00
crates/border-wars/src/responsive_scale.rs Outdated
@ -23,3 +23,3 @@
/// Calculates the ui_scale.0 depending on the default screen size
/// Calculates the ui_scale.0 depending on the [UILayoutSize]
/// in order to make the screen responsive.
tipragot commented 2024-03-09 17:50:26 +00:00
Contributor
Copy link

The screen is not the one who's responsive.

The screen is not the one who's responsive.
raphael added 1 commit 2024-03-09 17:52:10 +00:00
modifying doc strings
All checks were successful
Rust Checks / checks (push) Successful in 2m6s
Details
Rust Checks / checks (pull_request) Successful in 2m30s
Details
55616090d6
raphael requested review from tipragot 2024-03-09 17:52:25 +00:00
tipragot approved these changes 2024-03-09 17:53:08 +00:00
raphael merged commit d0c33523ce into main 2024-03-09 17:53:35 +00:00
raphael referenced this pull request from a commit 2024-03-09 17:53:36 +00:00
Renaming WindowSize (#77)
raphael deleted branch rename-window-size 2024-03-09 17:53:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tipragot
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Fix

Fix an issue

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Fix
Kind/Security
Kind/Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fish-cannard/border-wars#77
No description provided.
Delete branch "rename-window-size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?