fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Improve selection system #78

Merged
CoCo_Sol merged 14 commits from improve-selection into main 2024-03-19 15:08:43 +00:00
Conversation 0 Commits 14 Files changed 4 +49 -23
CoCo_Sol commented 2024-03-10 20:54:38 +00:00
Owner
Copy link

closes: #66

closes: #66
CoCo_Sol added this to the Gameplay milestone 2024-03-10 20:54:38 +00:00
CoCo_Sol added the
Kind/Enhancement
 label 2024-03-10 20:54:38 +00:00
CoCo_Sol self-assigned this 2024-03-10 20:54:38 +00:00
CoCo_Sol added 1 commit 2024-03-10 20:54:40 +00:00
update
All checks were successful
Rust Checks / checks (push) Successful in 6m27s
Details
Rust Checks / checks (pull_request) Successful in 3m10s
Details
907f217058
CoCo_Sol requested review from tipragot 2024-03-10 20:55:51 +00:00
CoCo_Sol requested review from raphael 2024-03-10 20:55:56 +00:00
CoCo_Sol removed review request for tipragot 2024-03-11 07:00:59 +00:00
CoCo_Sol removed review request for raphael 2024-03-11 07:01:00 +00:00
CoCo_Sol changed title from Improve selection system to WIP: Improve selection system 2024-03-11 07:03:08 +00:00
CoCo_Sol added 1 commit 2024-03-11 07:31:31 +00:00
save
Some checks failed
Rust Checks / checks (push) Has been cancelled
Details
Rust Checks / checks (pull_request) Failing after 1m24s
Details
bb0b7a82e0
CoCo_Sol added 1 commit 2024-03-11 07:32:43 +00:00
chnage doc
Some checks failed
Rust Checks / checks (push) Has been cancelled
Details
Rust Checks / checks (pull_request) Failing after 3m6s
Details
32624d0232
CoCo_Sol added 1 commit 2024-03-11 07:37:53 +00:00
save
Some checks failed
Rust Checks / checks (push) Waiting to run
Details
Rust Checks / checks (pull_request) Failing after 7s
Details
61c56bcdca
CoCo_Sol added 1 commit 2024-03-11 07:38:58 +00:00
save
Some checks failed
Rust Checks / checks (push) Failing after 5s
Details
Rust Checks / checks (pull_request) Failing after 5s
Details
6d66e67abe
CoCo_Sol requested review from tipragot 2024-03-11 07:40:44 +00:00
CoCo_Sol changed title from WIP: Improve selection system to Improve selection system 2024-03-11 07:41:01 +00:00
CoCo_Sol requested review from raphael 2024-03-11 07:41:25 +00:00
CoCo_Sol added 1 commit 2024-03-11 07:42:04 +00:00
fmt
Some checks failed
Rust Checks / checks (push) Failing after 3m9s
Details
Rust Checks / checks (pull_request) Has been cancelled
Details
5310e04f2e
CoCo_Sol added 1 commit 2024-03-11 07:46:15 +00:00
fix clippy
All checks were successful
Rust Checks / checks (push) Successful in 3m22s
Details
Rust Checks / checks (pull_request) Successful in 2m33s
Details
270e8c54d1
tipragot requested changes 2024-03-13 06:21:59 +00:00
tipragot left a comment
Contributor
Copy link

Any does not mean zero

Any does not mean zero
CoCo_Sol added 1 commit 2024-03-13 06:24:08 +00:00
update
All checks were successful
Rust Checks / checks (push) Successful in 4m44s
Details
Rust Checks / checks (pull_request) Successful in 2m58s
Details
419e36fb01
CoCo_Sol requested review from tipragot 2024-03-13 06:24:32 +00:00
tipragot requested changes 2024-03-13 06:27:50 +00:00
tipragot left a comment
Contributor
Copy link

Dont use thé entity index take juste the Entity directly

Dont use thé entity index take juste the Entity directly
CoCo_Sol added 1 commit 2024-03-13 06:37:48 +00:00
replace index for entity
Some checks failed
Rust Checks / checks (push) Failing after 2m43s
Details
Rust Checks / checks (pull_request) Failing after 3m34s
Details
9fe9e7fe2b
CoCo_Sol requested review from tipragot 2024-03-13 06:39:17 +00:00
tipragot requested changes 2024-03-13 06:40:47 +00:00
Dismissed
crates/border-wars/src/map/selected_tile.rs Outdated
@ -0,0 +9,4 @@
///
/// The event contains the entity of the clicked tile.
#[derive(Event)]
pub struct TileJustClicked(pub Entity);
tipragot commented 2024-03-13 06:40:42 +00:00
Contributor
Copy link

Why dis you change everything to selected but not this ?

Why dis you change everything to selected but not this ?
CoCo_Sol commented 2024-03-13 06:45:58 +00:00
Author
Owner
Copy link

I thought we would only need to know if a tile was clicked and not if it was selected, but I've just realized that it would be the same thing.

I thought we would only need to know if a tile was clicked and not if it was selected, but I've just realized that it would be the same thing.
CoCo_Sol marked this conversation as resolved
CoCo_Sol added 1 commit 2024-03-13 06:49:47 +00:00
remove event
Some checks failed
Rust Checks / checks (push) Failing after 5s
Details
Rust Checks / checks (pull_request) Failing after 4s
Details
e820a0e56c
CoCo_Sol added 1 commit 2024-03-13 06:51:00 +00:00
fix fmt
All checks were successful
Rust Checks / checks (push) Successful in 2m27s
Details
Rust Checks / checks (pull_request) Successful in 3m21s
Details
2a00b0f238
CoCo_Sol added 1 commit 2024-03-13 06:54:59 +00:00
remove doc
All checks were successful
Rust Checks / checks (push) Successful in 3m30s
Details
Rust Checks / checks (pull_request) Successful in 2m31s
Details
3d25021fde
CoCo_Sol requested review from tipragot 2024-03-13 09:15:30 +00:00
CoCo_Sol added 1 commit 2024-03-13 14:19:41 +00:00
change doc
All checks were successful
Rust Checks / checks (push) Successful in 3m17s
Details
Rust Checks / checks (pull_request) Successful in 2m49s
Details
7b348fa5b1
tipragot refused to review 2024-03-14 06:56:02 +00:00
tipragot dismissed tipragot's review 2024-03-14 06:56:13 +00:00
CoCo_Sol added 1 commit 2024-03-14 16:53:01 +00:00
Update crates/border-wars/src/map/selected_tile.rs
All checks were successful
Rust Checks / checks (push) Successful in 5m35s
Details
Rust Checks / checks (pull_request) Successful in 2m53s
Details
d3d2196abe
raphael approved these changes 2024-03-18 18:40:39 +00:00
CoCo_Sol merged commit 79092ea0f5 into main 2024-03-19 15:08:42 +00:00
CoCo_Sol referenced this pull request from a commit 2024-03-19 15:08:43 +00:00
Improve selection system (#78)
CoCo_Sol deleted branch improve-selection 2024-03-19 15:08:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tipragot
raphael
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Fix

Fix an issue

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Fix
Kind/Security
Kind/Testing
Milestone
Clear milestone
No items
No milestone
Gameplay
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
CoCo_Sol
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fish-cannard/border-wars#78
No description provided.
Delete branch "improve-selection"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?