fish-cannard/border-wars
fish-cannard/border-wars
5
3
Fork 0
generated from tipragot/rust
Code Issues 10 Pull requests 3 Actions Packages Projects Releases Wiki Activity

Add a responsive scaling for ui #73

Merged
raphael merged 11 commits from change-scaling into main 2024-03-09 17:24:22 +00:00
Conversation 0 Commits 11 Files changed 3 +41 -2
raphael commented 2024-03-03 01:04:13 +00:00
Owner
Copy link
No description provided.
raphael added this to the Renderer milestone 2024-03-03 01:04:13 +00:00
raphael added the
Kind/Feature
 label 2024-03-03 01:04:13 +00:00
raphael self-assigned this 2024-03-03 01:04:13 +00:00
raphael added 1 commit 2024-03-03 01:04:14 +00:00
Add a responsive scaling that calculates the ui_scale.depending on the size of the main node
All checks were successful
Rust Checks / checks (push) Successful in 3m11s
Details
Rust Checks / checks (pull_request) Successful in 1m56s
Details
0775704b8e
raphael requested review from tipragot 2024-03-03 01:04:28 +00:00
raphael requested review from CoCo_Sol 2024-03-03 01:04:29 +00:00
raphael added 1 commit 2024-03-03 09:57:28 +00:00
Adding more precision to the function docstring
All checks were successful
Rust Checks / checks (push) Successful in 4m25s
Details
Rust Checks / checks (pull_request) Successful in 2m28s
Details
f0671e12e2
CoCo_Sol approved these changes 2024-03-03 09:58:42 +00:00
Dismissed
tipragot requested changes 2024-03-03 11:18:52 +00:00
tipragot left a comment
Contributor
Copy link

Use constants and put it in a specific module for ui

Use constants and put it in a specific module for ui
tipragot requested changes 2024-03-06 07:42:17 +00:00
crates/border-wars/src/lib.rs Outdated
@ -20,2 +20,4 @@
Game,
}
/// Calculates the ui_scale.0 depending on the size of the main node
tipragot commented 2024-03-06 07:42:13 +00:00
Contributor
Copy link

What is the main node?

What is the main node?
CoCo_Sol marked this conversation as resolved
raphael added 1 commit 2024-03-08 07:20:51 +00:00
pull request
Some checks failed
Rust Checks / checks (push) Failing after 1m53s
Details
Rust Checks / checks (pull_request) Failing after 45s
Details
f0af5f4cfd
raphael dismissed CoCo_Sol's review 2024-03-08 07:20:53 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

raphael requested review from tipragot 2024-03-08 07:21:32 +00:00
raphael added 1 commit 2024-03-09 13:38:04 +00:00
reparation du programme
Some checks failed
Rust Checks / checks (push) Failing after 1m0s
Details
Rust Checks / checks (pull_request) Failing after 44s
Details
f0a4756260
raphael added 1 commit 2024-03-09 13:51:08 +00:00
Adding doc et repair the program
Some checks failed
Rust Checks / checks (push) Failing after 6s
Details
Rust Checks / checks (pull_request) Failing after 4s
Details
4b3da44d65
raphael added 1 commit 2024-03-09 13:57:03 +00:00
clarification du main node
Some checks failed
Rust Checks / checks (push) Failing after 5s
Details
Rust Checks / checks (pull_request) Failing after 4s
Details
11e4aef80d
raphael added 1 commit 2024-03-09 14:01:28 +00:00
adding an expect to the get_single() method
Some checks failed
Rust Checks / checks (push) Failing after 7s
Details
Rust Checks / checks (pull_request) Failing after 4s
Details
31bebd6542
raphael changed title from Add a responsive scaling that calculates the ui_scale depending on the size of the main node to Add a responsive scaling that calculates the ui_scale depending on the size of the default screen size 2024-03-09 14:01:56 +00:00
raphael removed review request for tipragot 2024-03-09 14:02:13 +00:00
raphael requested review from tipragot 2024-03-09 14:02:16 +00:00
raphael removed review request for tipragot 2024-03-09 14:07:04 +00:00
raphael requested review from tipragot 2024-03-09 14:07:12 +00:00
raphael added 1 commit 2024-03-09 14:28:16 +00:00
fmt
All checks were successful
Rust Checks / checks (push) Successful in 2m24s
Details
Rust Checks / checks (pull_request) Successful in 3m4s
Details
66b0cab4ff
CoCo_Sol reviewed 2024-03-09 14:41:27 +00:00
crates/border-wars/src/responsive_scale.rs Outdated
@ -0,0 +6,4 @@
const DEFAULT_WIDTH: f32 = 1280.;
/// The default height of the screen
const DEFAULT_HEIGHT: f32 = 720.;
CoCo_Sol commented 2024-03-09 14:41:26 +00:00
Owner
Copy link

You should put these constants in bevy's resources instead.
this can be changed in future settings.

You should put these constants in bevy's resources instead. this can be changed in future settings.
CoCo_Sol requested changes 2024-03-09 14:45:32 +00:00
CoCo_Sol left a comment
Owner
Copy link

resolves the comment above

resolves the comment above
tipragot requested changes 2024-03-09 15:19:33 +00:00
tipragot left a comment
Contributor
Copy link

I aggre with @CoCo_Sol

I aggre with @CoCo_Sol
raphael added 1 commit 2024-03-09 16:37:26 +00:00
Adding default size in ressource and create a plugin for the responsive scale
All checks were successful
Rust Checks / checks (push) Successful in 2m58s
Details
Rust Checks / checks (pull_request) Successful in 2m14s
Details
ab08b03660
raphael requested review from CoCo_Sol 2024-03-09 16:38:19 +00:00
raphael requested review from tipragot 2024-03-09 16:38:21 +00:00
raphael changed title from Add a responsive scaling that calculates the ui_scale depending on the size of the default screen size to Add a responsive scaling for ui 2024-03-09 16:39:21 +00:00
raphael added 1 commit 2024-03-09 16:42:46 +00:00
ajout de points a la fin des phrases
Some checks failed
Rust Checks / checks (push) Has been cancelled
Details
Rust Checks / checks (pull_request) Successful in 2m39s
Details
5ea30d3501
raphael added 1 commit 2024-03-09 16:45:23 +00:00
Merge branch 'main' into change-scaling
All checks were successful
Rust Checks / checks (pull_request) Successful in 3m4s
Details
Rust Checks / checks (push) Successful in 2m34s
Details
adead2fb44
CoCo_Sol approved these changes 2024-03-09 16:54:25 +00:00
raphael merged commit 6e982a3935 into main 2024-03-09 17:24:22 +00:00
raphael deleted branch change-scaling 2024-03-09 17:24:24 +00:00
raphael referenced this pull request from a commit 2024-03-09 17:24:25 +00:00
Add a responsive scaling for ui (#73)
Sign in to join this conversation.
Reviewers
No reviewers
tipragot
CoCo_Sol
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Fix

Fix an issue

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Fix
Kind/Security
Kind/Testing
Milestone
Clear milestone
No items
No milestone
Renderer
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
raphael
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fish-cannard/border-wars#73
No description provided.
Delete branch "change-scaling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?