From 0b750da56b6cd36b9db39a6353a7421731d9046d Mon Sep 17 00:00:00 2001
From: CoCo_Sol <solois.corentin@gmail.com>
Date: Sat, 6 Apr 2024 11:23:07 +0000
Subject: [PATCH] Fix speed movement of camera by adding delta time (#114)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reviewed-on: https://git.tipragot.fr/fish-cannard/border-wars/pulls/114
Reviewed-by: Raphaël <r.lauray@outlook.fr>
---
 crates/border-wars/src/camera.rs | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/crates/border-wars/src/camera.rs b/crates/border-wars/src/camera.rs
index b22dd92..f1ace8c 100644
--- a/crates/border-wars/src/camera.rs
+++ b/crates/border-wars/src/camera.rs
@@ -75,7 +75,7 @@ fn init_resources_for_camera(mut commands: Commands) {
         left: KeyCode::Q,
     });
 
-    commands.insert_resource(CameraSpeedMouvement(10.0));
+    commands.insert_resource(CameraSpeedMouvement(400.0));
     commands.insert_resource(CameraSpeedScale(0.1));
     commands.insert_resource(MinimumScale(0.1));
     commands.insert_resource(MaximumScale(10.0));
@@ -87,20 +87,23 @@ fn keyboard_movement_system(
     keys: Res<Input<KeyCode>>,
     keys_settings: Res<KeysMovementSettings>,
     movement_speed: Res<CameraSpeedMouvement>,
+    delta_time: Res<Time>,
 ) {
     for mut transform in query.iter_mut() {
-        let mut target = Vec3::ZERO;
+        let mut dx = 0.0;
+        let mut dy = 0.0;
         for key in keys.get_pressed() {
             match *key {
-                value if value == keys_settings.up => target.y += movement_speed.0,
-                value if value == keys_settings.down => target.y -= movement_speed.0,
-                value if value == keys_settings.right => target.x += movement_speed.0,
-                value if value == keys_settings.left => target.x -= movement_speed.0,
+                up if up == keys_settings.up => dy += movement_speed.0,
+                down if down == keys_settings.down => dy -= movement_speed.0,
+                right if right == keys_settings.right => dx += movement_speed.0,
+                left if left == keys_settings.left => dx -= movement_speed.0,
                 _ => continue,
             }
         }
 
-        transform.translation += target;
+        transform.translation.x += dx * delta_time.delta_seconds();
+        transform.translation.y += dy * delta_time.delta_seconds();
     }
 }